Code Quality Basics - What Is Refactoring?


Image


As you make enhancements to your source code, how do you ensure that you are adhering to all the standards? What is Refactoring? How can you refactor your code?

You will learn

  • What is code refactoring?
  • What are the challenges with having bad code?
  • Why should you refactor code?
  • What are the best practices in refactoring code?

Free Courses - Learn in 10 Steps

Article Series

This is the seventh article in a series of eight articles on Code Quality

Why Refactoring?

Suppose you end up working in a project which has code that looks like this:


	public Lock isLockAvailableForFile(long clientID, String status, boolean firstScreen, User user, List list) {
		Date sysTime = new Date();
		Lock lock = new Lock();
		if(list.size() > 0 && list.get(0) != null) {
			Object[] o1 = (Object[]) list.get(0);
			String userId = (String) o1[0];
			Date lockTimestamp = (Date) o1[1];
		
			if(userId != null) {
				//The message shown to the user
				String lockMsg = Constants.LOCK_REASON.replaceAll("@@[email protected]@", userId);

				//if userId is present, then lockTimestamp will also be present
				//72000000 milliseconds equals to 2 hours
				if(sysTime.gettime() - locktimestamp.getTime() > 7200000) {
					//The new user should attain lock only in the first screen
					//If 2 hours expires when user is not present on 1st screen, then user Id...
					if(firstScreen 
						|| userId.equalsIgnoreCase(user.getUserId())) {
						//to set the file access to write mode
						lock.setReadAccess(false);
						Logger.debug(
									 "Write access is permitted to the User for client {0}",
									clientId);
						return lock;
					}

					/*   ...  BLAH BLAH BLAH !!!  ...   */
				}
			}
		}
	}

How easy do you think it is to maintain this kind of code?

Let’s say you need to make a change in the piece of code shown above. Is it straightforward, or is it a difficult task?

One thing you can do with difficult code such as this, is to improve its structure, without changing its functionality. Such a transformation is called refactoring.

Here is what the above code will look like when refactored:


	public Lock isLockAvailableForFile(boolean isFirstScreen, User user, List list) {
		if(isListEmpty(list)) {
			return lockWithWriteAccess();
		}
		Object[] lockObject = (Object[]) list.get(0);
		String userId = (String) lockObject[0];
		Date lockTimestamp = (Date) lockObject[1];

		if(userId == null) {
			return lockWithWriteAccess();
		}

		boolean userHasLockedEarlier = userId.equalsIgnoreCase(user.userId);
		boolean lockPeriodExceeded = new Date().getTime() -
									 lockTimeStamp.getTime > 2 * 60 * 60 * 1000;

		if(userHasLockEarlier)
			return lockWithWriteAccess();
		if(lockPeriodExceeded && isFirstScreen)
			return lockWithWriteAccess();

		return lockWithReadAccess(userId);
	}

What is Refactoring?

Refactoring involves altering the structure of code, without changing its behavior.

The goals of refactoring include making the code have less duplication, and making it more readable.

It may sound very easy, but refactoring is actually a very difficult task. The most difficult part is deciding on a sequence of refactoring steps.

In the example we saw above, how can you be sure that making the alterations shown, will keep the functionality of the code intact?

Build A Test Bed

The only way you can refactor with confidence, is by building a test bed. Of course, this may not be necessary for very basic forms of refactoring, such as renaming a variable, or extracting a method. Except for such basic refactoring, one would need to make sure that there are very good unit tests in place, to test the code.

If such unit tests are not available, then you need to write tests first. When you have tests, you can improve the code in small steps. At each stage, make the changes, and run the set of tests. If everything turns out fine, then go ahead with the next refactoring step.

Do check out our video on the same topic:

image info

Summary

Continuous Refactoring, aided by tests, leads to clean code. To be able to continuously refactor, you need good tests. With exprerience, you get better at refactoring, and will figure out a good sequence of steps to approach refactoring, in general.

Best Selling Udemy Courses

Image
Image Image Image Image Image Image Image Image Image

Join 450,000 Learners and 30+ Amazing Courses

350,000 Learners are learning everyday with our Best Selling Courses : Spring Boot Microservices, Spring, Spring Boot, Web Services, Hibernate, Full Stack React, Full Stack Angular, Python, Spring Interview Guide, Java Interview, Java Functional Programming, AWS, Docker, Kubernetes, PCF, AWS Fargate and Azure


Do not know where to start your learning journey? Check out our amazing learning paths:
Learning Path 01 - Spring and Spring Boot Web Applications and API Developer,
Learning Path 02 - Full Stack Developer with Spring Boot, React & Angular,
Learning Path 03 - Cloud Microservices Developer with Docker and Kubernetes,
Learning Path 04 - Learn Cloud with Spring Boot, AWS, Azure and PCF and
Learning Path 05 - Learn AWS with Microservices, Docker and Kubernetes


Subscribe

FREE COURSES



Related Posts

Writing Integration Tests for Rest Services with Spring Boot

Setting up a basic REST Service with Spring Boot is a cake walk. We will go one step further and add great integration tests!

Integrating Spring Boot and Spring JDBC with H2 and Starter JDBC

Learn using Spring Boot Starter JDBC to connect Spring Boot to H2 (in memory database) using Spring JDBC. You will create a simple project with Spring Boot. You will add code to the project to connect to a database using Spring JDBC. You will learn to implement the basic CRUD methods.

JUnit Tutorial for Beginners in 5 Steps

JUnit Tutorial for Beginners in 5 Steps. Setting up a basic JUnit example and understanding the basics of junit.

JPA and Hibernate Tutorial For Beginners - 10 Steps with Spring Boot and H2

JPA and Hibernate in 10 Steps with H2 - Setting up a basic project example with Spring Boot and in memory database H2. Its a cake walk.

Spring Boot Tutorial For Beginners in 10 Steps

Introduction to Spring Boot in 10 Steps. Learn the basics of Spring Boot setting up a basic project example with Spring Boot.

Spring Framework Tutorial for Beginners - Your First 10 Steps

Learn the basics of Spring Framework setting up a very simple example.

JPA and Hibernate Tutorial using Spring Boot Data JPA

Complete journey starting from JDBC to JPA to Spring Data JPA using an example with Spring Boot Data JPA starter project. We use Hibernate as the JPA Implementation.

Creating a Web Application with Spring Boot with JSP

Setting up a basic web application with Spring Boot is a cake walk. We will create a simple web application using Spring Initializr and add JSP features to it.

What is Spring Boot Auto Configuration?

Auto Configuration is the most important feature in Spring Boot. In this tutorial, we will learn important concepts about Auto Configuration with a couple of examples.

Unit Testing Rest Services with Spring Boot and JUnit

Setting up a Basic REST Service with Spring Boot is a cake walk. We will go one step further and add great unit tests to our RESTful Service.


Search